Home Original page

test: improve test-dgram-send-cb-quelches-error by Trott · Pull Request #30545 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Nov 19, 2019

addaleax

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 19, 2019

Trott added a commit to Trott/io.js that referenced this pull request

Nov 21, 2019 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request

Nov 21, 2019 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request

Nov 21, 2019 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 21, 2019 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 21, 2019 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 21, 2019 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Dec 1, 2019 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Dec 1, 2019 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Dec 1, 2019 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 17, 2019 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 17, 2019 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 17, 2019 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>