assert,util: always verify both sides by BridgeAR · Pull Request #30764 · nodejs/node

assert,util: always verify both sides by BridgeAR · Pull Request #30764 · nodejs/node

added 2 commits

December 2, 2019 15:33

This veryfies that both input arguments are always of the identical
type. It was possible to miss a few cases before. This change applies
to all deep equal assert functions (e.g., `assert.deepStrictEqual()`)
and to `util.isDeepStrictEqual()`.

This makes sure the assertion does not depend on the argument order.
It also removes comments that do not apply anymore and verifies the
behavior for the loose and strict implementation.

BridgeAR changed the title ~~assert: always verify both sides~~ assert,util: always verify both sides

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

ljharb added a commit to inspect-js/node-deep-equal that referenced this pull request

ljharb added a commit to inspect-js/node-deep-equal that referenced this pull request

ljharb added a commit to inspect-js/node-deep-equal that referenced this pull request

ljharb added a commit to inspect-js/node-deep-equal that referenced this pull request

ljharb added a commit to inspect-js/node-deep-equal that referenced this pull request

ljharb added a commit to inspect-js/node-deep-equal that referenced this pull request

aks- approved these changes Dec 5, 2019

BridgeAR added a commit that referenced this pull request

This veryfies that both input arguments are always of the identical
type. It was possible to miss a few cases before. This change applies
to all deep equal assert functions (e.g., `assert.deepStrictEqual()`)
and to `util.isDeepStrictEqual()`.

PR-URL: #30764
Refs: #30743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR added a commit that referenced this pull request

This makes sure the assertion does not depend on the argument order.
It also removes comments that do not apply anymore and verifies the
behavior for the loose and strict implementation.

PR-URL: #30764
Refs: #30743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

This veryfies that both input arguments are always of the identical
type. It was possible to miss a few cases before. This change applies
to all deep equal assert functions (e.g., `assert.deepStrictEqual()`)
and to `util.isDeepStrictEqual()`.

PR-URL: #30764
Refs: #30743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

Sep 18, 2021

This was referenced

Sep 29, 2022

This was referenced

Oct 5, 2022

This was referenced

Oct 8, 2022