Home Original page

readline: eagerly load string_decoder by BridgeAR · Pull Request #30807 · nodejs/node

@BridgeAR 

There was no point in lazy loading the string_decoder, since it
would be used in all cases anyway.

@nodejs-github-bot added the readline

Issues and PRs related to the built-in readline module.

label

Dec 5, 2019

addaleax

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 6, 2019

Trott pushed a commit that referenced this pull request

Dec 7, 2019 
There was no point in lazy loading the string_decoder, since it
would be used in all cases anyway.

PR-URL: #30807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Dec 9, 2019 
There was no point in lazy loading the string_decoder, since it
would be used in all cases anyway.

PR-URL: #30807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Jan 14, 2020 
There was no point in lazy loading the string_decoder, since it
would be used in all cases anyway.

PR-URL: #30807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR deleted the refactor-readline-lazy-loading branch

January 20, 2020 12:07

BethGriggs pushed a commit that referenced this pull request

Feb 6, 2020 
There was no point in lazy loading the string_decoder, since it
would be used in all cases anyway.

PR-URL: #30807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>