Home Original page

build,win: support building MSI with VS2019 by joaocgreis · Pull Request #30895 · nodejs/node

@joaocgreis 

Explicitly pass the WiX SDK directory when building the MSI. WiX
doesn't (yet?) have a directory for VS2019, so use the one for VS2017
which should be compatible.

@nodejs-github-bot nodejs-github-bot added install

Issues and PRs related to the installers.

meta

Issues and PRs related to the general management of the project.

tools

Issues and PRs related to the tools directory.

labels

Dec 11, 2019

richardlau

richardlau

@joaocgreis

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 11, 2019

Trott pushed a commit that referenced this pull request

Dec 13, 2019 
Explicitly pass the WiX SDK directory when building the MSI. WiX
doesn't (yet?) have a directory for VS2019, so use the one for VS2017
which should be compatible.

PR-URL: #30895
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 17, 2019 
Explicitly pass the WiX SDK directory when building the MSI. WiX
doesn't (yet?) have a directory for VS2019, so use the one for VS2017
which should be compatible.

PR-URL: #30895
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>