http2: make http2/compat.write more http/1 compliant by ronag · Pull Request #30964

http2: make http2/compat.write more http/1 compliant by ronag · Pull Request #30964 · nodejs/node

added the http2

Issues or PRs related to the http2 subsystem.

label

Dec 14, 2019

ronag mentioned this pull request

Dec 14, 2019

ronag changed the title ~~http2: make HTTP2ServerResponse more streams compliant~~ http2: make HTTP2ServerResponse.write more streams compliant

Dec 14, 2019

ronag changed the title ~~http2: make HTTP2ServerResponse.write more streams compliant~~ http2: make http2/compat.write more http/1 compliant

Dec 15, 2019

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 25, 2019

BridgeAR removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 25, 2019

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

Refs: nodejs#29529

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 1, 2020

BridgeAR pushed a commit that referenced this pull request

Jan 1, 2020

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

PR-URL: #30964
Refs: #29529
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Jan 3, 2020

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

PR-URL: #30964
Refs: #29529
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

sxa pushed a commit to sxa/node that referenced this pull request

Jan 21, 2020

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

PR-URL: nodejs#30964
Refs: nodejs#29529

sxa mentioned this pull request

Jan 21, 2020

4 tasks

sxa pushed a commit to sxa/node that referenced this pull request

Jan 21, 2020

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

PR-URL: nodejs#30964
Refs: nodejs#29529
Backport-PR-URL: nodejs#31444

MylesBorins pushed a commit that referenced this pull request

Jan 30, 2020

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

Backport-PR-URL: #31444
PR-URL: #30964
Refs: #29529
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Feb 6, 2020

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

Backport-PR-URL: #31444
PR-URL: #30964
Refs: #29529
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>