Home Original page

util: improve prototype inspection using `inspect()` and `showHidden` by BridgeAR · Pull Request #31113 · nodejs/node

@nodejs-github-bot added the util

Issues and PRs related to the built-in util module.

label

Dec 27, 2019

@BridgeAR 

The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 31, 2019

BridgeAR added a commit that referenced this pull request

Jan 2, 2020 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR added a commit that referenced this pull request

Jan 3, 2020 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@BridgeAR BridgeAR deleted the 2019-12-27-fix-inspect-prototype branch

January 20, 2020 12:09

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Jan 22, 2020 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: nodejs#31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 30, 2020 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

Backport-PR-URL: #31431
PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Feb 6, 2020 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

Backport-PR-URL: #31431
PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>