Home Original page

crypto: modernize DH/ECDH/ECDH-ES by tniessen · Pull Request #31178 · nodejs/node

@tniessen added wip

Issues and PRs that are still a work in progress.

crypto

Issues and PRs related to the crypto subsystem.

semver-minor

PRs that contain new features and should be released in the next minor version.

labels

Jan 3, 2020

BridgeAR

sam-github

bnoordhuis

addaleax

lundibundi

@tniessen tniessen marked this pull request as ready for review

January 8, 2020 14:27

@BridgeAR BridgeAR removed the wip

Issues and PRs that are still a work in progress.

label

Jan 9, 2020

BridgeAR

addaleax pushed a commit that referenced this pull request

Mar 11, 2020 
Refs: #31178
Refs: #31445

PR-URL: #31873
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
The new key type 'dh' corresponds to EVP_PKEY_DH.

PR-URL: nodejs#31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
PR-URL: nodejs#31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
This allows using the generateKeyPair API for DH instead of the old
stateful DH APIs.

PR-URL: nodejs#31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
Currently, Node.js has separate (stateful) APIs for DH/ECDH, and no
support for ECDH-ES. This commit adds a single stateless function to
compute the DH/ECDH/ECDH-ES secret based on two KeyObjects.

PR-URL: nodejs#31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
test-crypto-keygen and test-crypto-dh-stateless are currently flaky
on ARM CI systems due to their slow CPUs.

PR-URL: nodejs#31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
The new key type 'dh' corresponds to EVP_PKEY_DH.

PR-URL: #31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
PR-URL: #31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
This allows using the generateKeyPair API for DH instead of the old
stateful DH APIs.

PR-URL: #31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
Currently, Node.js has separate (stateful) APIs for DH/ECDH, and no
support for ECDH-ES. This commit adds a single stateless function to
compute the DH/ECDH/ECDH-ES secret based on two KeyObjects.

PR-URL: #31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
test-crypto-keygen and test-crypto-dh-stateless are currently flaky
on ARM CI systems due to their slow CPUs.

PR-URL: #31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

@panva panva mentioned this pull request

Feb 3, 2021

8 tasks