Home Original page

stream: make readable & writable computed by ronag · Pull Request #31197 · nodejs/node

@nodejs-github-bot added the stream

Issues and PRs related to the stream subsystem.

label

Jan 5, 2020

@ronag ronag changed the title stream: Writable.writable computed stream: readable & writable computed

Jan 5, 2020

@lundibundi lundibundi added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jan 5, 2020

ronag

ronag

@ronag ronag added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed wip

Issues and PRs that are still a work in progress.

labels

Jan 31, 2020

addaleax

@ronag @addaleax 

Co-Authored-By: Anna Henningsen <github@addaleax.net>

@ronag

@ronag

@addaleax addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 7, 2020

mcollina

Trott

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 8, 2020

ronag added a commit that referenced this pull request

Feb 8, 2020 
This makes readable and writable automatically computed based
on the stream state.

Effectivly deprecating/discouraging manual management of this.

Makes the properties  more consistent and easier to reason about.

Fixes: #29377

PR-URL: #31197
Refs: #29377
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

ronag added a commit to nxtedition/node that referenced this pull request

Feb 15, 2020

@ronag ronag mentioned this pull request

Feb 16, 2020

4 tasks

ronag added a commit that referenced this pull request

Feb 17, 2020 
A remainder from a previous refactoring.

Refs: #31197

PR-URL: #31805
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>