Home Original page

Fix dispose without checking by jc-lab · Pull Request #31260 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

v8 engine

Issues and PRs related to the V8 dependency.

labels

Jan 8, 2020 
If created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called.

joyeecheung

addaleax

@addaleax addaleax added embedding

Issues and PRs related to embedding Node.js in another project.

and removed v8 engine

Issues and PRs related to the V8 dependency.

labels

Jan 14, 2020

addaleax pushed a commit to addaleax/node that referenced this pull request

Mar 12, 2020 
If created platform with CreatePlatform, the crash occurs because
it does not check if it was initialized to v8_platform
when DisposePlatform was called.

Refs: nodejs#31260

addaleax added a commit that referenced this pull request

Mar 21, 2020 
If created platform with CreatePlatform, the crash occurs because
it does not check if it was initialized to v8_platform
when DisposePlatform was called.

Refs: #31260
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: #30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

addaleax added a commit to addaleax/node that referenced this pull request

Sep 23, 2020 
If created platform with CreatePlatform, the crash occurs because
it does not check if it was initialized to v8_platform
when DisposePlatform was called.

Refs: nodejs#31260
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

addaleax added a commit that referenced this pull request

Sep 23, 2020 
If created platform with CreatePlatform, the crash occurs because
it does not check if it was initialized to v8_platform
when DisposePlatform was called.

Backport-PR-URL: #35241
Refs: #31260
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: #30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>