Home Original page

test: fix flaky test-memory-usage by addaleax · Pull Request #31602 · nodejs/node

@addaleax 

abe6a2e introduced a test that verifies that ArrayBuffer
allocations are tracked. However, V8 supports concurrent freeing
of such allocations on background threads, meaning that the results
may be subject to race conditions sometimes.

Disabling concurrent freeing makes the test pass consistently.

Refs: nodejs#31550

@addaleax added test

Issues and PRs related to the tests.

process

Issues and PRs related to the process subsystem.

flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

fast-track

PRs that do not need to wait for 72 hours to land.

labels

Feb 1, 2020

gireeshpunathil

lundibundi

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 1, 2020

addaleax added a commit that referenced this pull request

Feb 1, 2020 
abe6a2e introduced a test that verifies that ArrayBuffer
allocations are tracked. However, V8 supports concurrent freeing
of such allocations on background threads, meaning that the results
may be subject to race conditions sometimes.

Disabling concurrent freeing makes the test pass consistently.

Refs: #31550

PR-URL: #31602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

Feb 1, 2020 
Basically, any of the tests that failed in the runs for
nodejs#31602 which was not already
marked as flaky.

addaleax added a commit that referenced this pull request

Feb 1, 2020 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere pushed a commit that referenced this pull request

Feb 17, 2020 
abe6a2e introduced a test that verifies that ArrayBuffer
allocations are tracked. However, V8 supports concurrent freeing
of such allocations on background threads, meaning that the results
may be subject to race conditions sometimes.

Disabling concurrent freeing makes the test pass consistently.

Refs: #31550

PR-URL: #31602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Feb 17, 2020 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 15, 2020 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 17, 2020 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 30, 2020 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
abe6a2e introduced a test that verifies that ArrayBuffer
allocations are tracked. However, V8 supports concurrent freeing
of such allocations on background threads, meaning that the results
may be subject to race conditions sometimes.

Disabling concurrent freeing makes the test pass consistently.

Refs: nodejs#31550

PR-URL: nodejs#31602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
abe6a2e introduced a test that verifies that ArrayBuffer
allocations are tracked. However, V8 supports concurrent freeing
of such allocations on background threads, meaning that the results
may be subject to race conditions sometimes.

Disabling concurrent freeing makes the test pass consistently.

Refs: #31550

PR-URL: #31602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>