Home Original page

test: show child stderr output in largepages test by bnoordhuis · Pull Request #31612 · nodejs/node

Trott

Trott previously approved these changes Feb 2, 2020

@Trott Trott added fast-track

PRs that do not need to wait for 72 hours to land.

and removed fast-track

PRs that do not need to wait for 72 hours to land.

labels

Feb 2, 2020

@bnoordhuis 

The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: nodejs#31547 (comment)

@Trott Trott added the fast-track

PRs that do not need to wait for 72 hours to land.

label

Feb 2, 2020

addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 2, 2020

addaleax pushed a commit that referenced this pull request

Feb 2, 2020 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

PR-URL: #31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

codebytere pushed a commit that referenced this pull request

Feb 17, 2020 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

PR-URL: #31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: nodejs#31547 (comment)

PR-URL: nodejs#31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 28, 2020 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

PR-URL: #31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>