Home Original page

net: autoDestroy Socket by ronag · Pull Request #31806 · nodejs/node

@ronag added net

Issues and PRs related to the net subsystem.

stream

Issues and PRs related to the stream subsystem.

labels

Feb 15, 2020

@mcollina mcollina added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Feb 15, 2020

mcollina

addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 15, 2020

lpinca

lpinca previously approved these changes Feb 16, 2020

lundibundi

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 1, 2020

mcollina

addaleax

ronag added a commit that referenced this pull request

Apr 2, 2020 
Refactors net.Socket into using autoDestroy functionality
of streams.

PR-URL: #31806
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This was referenced

Apr 12, 2020

@ronag ronag mentioned this pull request

Apr 20, 2020

4 tasks

ronag referenced this pull request

Apr 28, 2020 
Writable stream could emit 'finish' after 'close'.

PR-URL: #32933
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

@ronag ronag mentioned this pull request

Apr 28, 2020

4 tasks

@Trott Trott mentioned this pull request

Jul 12, 2020

Trott added a commit to Trott/io.js that referenced this pull request

Jul 12, 2020

@Trott Trott mentioned this pull request

Jul 12, 2020

2 tasks

addaleax pushed a commit that referenced this pull request

Jul 14, 2020 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

MylesBorins pushed a commit that referenced this pull request

Jul 14, 2020 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

MylesBorins pushed a commit that referenced this pull request

Jul 16, 2020 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

cjihrig pushed a commit that referenced this pull request

Jul 23, 2020 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

This was referenced

Jul 5, 2022