benchmark: remove problematic tls params by mscdex · Pull Request #31816 · nodejs/node

@nodejs-github-bot added benchmark

Issues and PRs related to the benchmark subsystem.

test

Issues and PRs related to the tests.

tls

Issues and PRs related to the tls subsystem.

labels

Feb 16, 2020

@mscdex

These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: nodejs#31816
Reviewed-By: James M Snell <jasnell@gmail.com>

@mscdex mscdex deleted the benchmark-tls-remove-slow-param branch

March 6, 2020 04:44

MylesBorins pushed a commit that referenced this pull request

Mar 9, 2020
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: #31816
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 16, 2020
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: #31816
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 17, 2020
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: #31816
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 23, 2020
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: #31816
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 30, 2020
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: #31816
Reviewed-By: James M Snell <jasnell@gmail.com>