src: don't run bootstrapper in CreateEnvironment by codebytere · Pull Request #31910 · nodejs/node

src: don't run bootstrapper in CreateEnvironment by codebytere · Pull Request #31910 · nodejs/node

Skip to content

Conversation

nodejs-github-bot added build

Issues and PRs related to build files or the CI.

Issues and PRs that require attention from people who are familiar with C++.

labels

codebytere changed the title ~~src,lib: don't run bootstrapper in CreateEnvironment~~ src: don't run bootstrapper in CreateEnvironment

codebytere added a commit that referenced this pull request

PR-URL: #31910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere deleted the createenv-remove-some=bootstrap branch

February 27, 2020 21:50

codebytere added a commit that referenced this pull request

PR-URL: #31910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

codebytere added a commit that referenced this pull request

PR-URL: #31910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere added a commit that referenced this pull request

PR-URL: #31910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit that referenced this pull request

Refs: #31910

PR-URL: #30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

codebytere added a commit that referenced this pull request

PR-URL: #31910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

addaleax added a commit to addaleax/node that referenced this pull request

Refs: nodejs#31910

PR-URL: nodejs#30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

addaleax added a commit that referenced this pull request

Refs: #31910

Backport-PR-URL: #35241
PR-URL: #30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>