Home Original page

test: add coverage for FSWatcher exception by Trott · Pull Request #32057 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 3, 2020

@Trott Trott mentioned this pull request

Mar 3, 2020

4 tasks

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 5, 2020

antsmartian

Trott added a commit to Trott/io.js that referenced this pull request

Mar 5, 2020 
Remove convenience function for internal assertions. It is only used
once.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32057
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request

Mar 5, 2020 
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32057
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

@Trott Trott deleted the common-int-assert branch

March 5, 2020 15:10

MylesBorins pushed a commit that referenced this pull request

Mar 9, 2020 
Remove convenience function for internal assertions. It is only used
once.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32057
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 9, 2020 
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32057
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>