Home Original page

[v13.x backport] pipeline destroy compat by ronag · Pull Request #32212 · nodejs/node

@ronag ronag added the stream

Issues and PRs related to the stream subsystem.

label

Mar 11, 2020

@ronag ronag mentioned this pull request

Mar 11, 2020

@ronag ronag mentioned this pull request

Mar 11, 2020

4 tasks

@ronag ronag changed the title [v13.x backport] avoid destroying http1 objects [v13.x backport] pipeline destroy compat

Mar 11, 2020 
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.

Fixes: nodejs#32184

Backport-PR-URL: nodejs#32212
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

Fixes: nodejs@4d93e10#commitcomment-37751035

Backport-PR-URL: nodejs#32212

MylesBorins pushed a commit that referenced this pull request

Mar 12, 2020 
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.

Fixes: #32184

Backport-PR-URL: #32212
PR-URL: #32197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 12, 2020 
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

Backport-PR-URL: #32212
PR-URL: #32198
Refs: 4d93e10#commitcomment-37751035
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>