Home Original page

test: improve test-cluster-net-listen-ipv6only-false by Trott · Pull Request #32398 · nodejs/node

addaleax

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 23, 2020 
Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32398
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32398
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@Trott Trott deleted the par-cluster branch

March 28, 2020 06:18

addaleax pushed a commit that referenced this pull request

Mar 30, 2020 
Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32398
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request

Mar 30, 2020 
Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32398
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 22, 2020 
Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32398
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 22, 2020 
Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32398
Reviewed-By: Anna Henningsen <anna@addaleax.net>