Home Original page

build: disable -Wattributes warnings on aix by bnoordhuis · Pull Request #32419 · nodejs/node

@bnoordhuis 

Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

@bnoordhuis added build

Issues and PRs related to build files or the CI.

aix

Issues and PRs related to the AIX platform.

labels

Mar 22, 2020

richardlau

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 29, 2020

addaleax

addaleax pushed a commit that referenced this pull request

Mar 29, 2020 
Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

PR-URL: #32419
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request

Mar 30, 2020 
Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

PR-URL: #32419
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 22, 2020 
Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

PR-URL: #32419
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>