Home Original page

src: cleanup DestroyParam when Environment exits by addaleax · Pull Request #32421 · nodejs/node

@addaleax 

Otherwise, this leaks memory if the weak callback is never called.

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Mar 22, 2020

devnexen

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 22, 2020

addaleax added a commit that referenced this pull request

Mar 27, 2020 
Otherwise, this leaks memory if the weak callback is never called.

PR-URL: #32421
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@addaleax addaleax deleted the destroy-param-cleanup branch

March 27, 2020 15:05

addaleax added a commit that referenced this pull request

Mar 30, 2020 
Otherwise, this leaks memory if the weak callback is never called.

PR-URL: #32421
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Apr 22, 2020 
Otherwise, this leaks memory if the weak callback is never called.

PR-URL: #32421
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>