Home Original page

test: use common.buildType in embedding test by addaleax · Pull Request #32422 · nodejs/node

@addaleax 

This un-breaks testing in the case of `./configure --debug-node`.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 22, 2020

richardlau

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 22, 2020

addaleax added a commit that referenced this pull request

Mar 27, 2020 
This un-breaks testing in the case of `./configure --debug-node`.

PR-URL: #32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

Sep 23, 2020 
This un-breaks testing in the case of `./configure --debug-node`.

PR-URL: nodejs#32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Sep 23, 2020 
This un-breaks testing in the case of `./configure --debug-node`.

Backport-PR-URL: #35241
PR-URL: #32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>