Home Original page

stream: emit 'pause' on unpipe by ronag · Pull Request #32476 · nodejs/node

@ronag 

unpipe should use pause() instead of mutating
state.flowing directly so that pausing side
effects such as emitting 'pause' are properly
performed.

Fixes: nodejs#32470

@nodejs-github-bot added the stream

Issues and PRs related to the stream subsystem.

label

Mar 24, 2020

hassaanp

addaleax

mcollina

MylesBorins pushed a commit that referenced this pull request

Mar 26, 2020 
unpipe should use pause() instead of mutating
state.flowing directly so that pausing side
effects such as emitting 'pause' are properly
performed.

Fixes: #32470

PR-URL: #32476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 26, 2020 
unpipe should use pause() instead of mutating
state.flowing directly so that pausing side
effects such as emitting 'pause' are properly
performed.

Fixes: #32470

PR-URL: #32476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>