Home Original page

test: revise test-http-client-default-headers-exist by Trott · Pull Request #32493 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 25, 2020

jasnell

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 27, 2020

addaleax

@Trott 

* Remove assert.strictEqual where assert.ok suffices
* Replace countdown with Promise.all()

PR-URL: nodejs#32493
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@Trott Trott deleted the def-headers branch

March 28, 2020 00:00

addaleax pushed a commit that referenced this pull request

Mar 30, 2020 
* Remove assert.strictEqual where assert.ok suffices
* Replace countdown with Promise.all()

PR-URL: #32493
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 22, 2020 
* Remove assert.strictEqual where assert.ok suffices
* Replace countdown with Promise.all()

PR-URL: #32493
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>