test: wait for message from parent in embedding cctest by addaleax · Pull Request #32563

test: wait for message from parent in embedding cctest by addaleax · Pull Request #32563 · nodejs/node

I’ve seen this fail a few times in CI, presumably because the
inspector commmand did not reach the child thread in time.
Explicitly waiting seems to solve that.

Refs: nodejs#30467

added the test

Issues and PRs related to the tests.

label

Mar 30, 2020

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 30, 2020

addaleax added a commit that referenced this pull request

Apr 2, 2020

I’ve seen this fail a few times in CI, presumably because the
inspector commmand did not reach the child thread in time.
Explicitly waiting seems to solve that.

Refs: #30467

PR-URL: #32563
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax deleted the test-inspector-embedding-wait branch

April 2, 2020 15:44

BethGriggs pushed a commit that referenced this pull request

Apr 7, 2020

I’ve seen this fail a few times in CI, presumably because the
inspector commmand did not reach the child thread in time.
Explicitly waiting seems to solve that.

Refs: #30467

PR-URL: #32563
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

Sep 23, 2020

I’ve seen this fail a few times in CI, presumably because the
inspector commmand did not reach the child thread in time.
Explicitly waiting seems to solve that.

Refs: nodejs#30467

PR-URL: nodejs#32563
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Sep 23, 2020

I’ve seen this fail a few times in CI, presumably because the
inspector commmand did not reach the child thread in time.
Explicitly waiting seems to solve that.

Refs: #30467

Backport-PR-URL: #35241
PR-URL: #32563
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>