Home Original page

lib: remove unnecesary else block by ddazal · Pull Request #32644 · nodejs/node

@ddazal 

The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary

@nodejs-github-bot added the child_process

Issues and PRs related to the child_process subsystem.

label

Apr 3, 2020

addaleax

BridgeAR

juanarbol

@juanarbol juanarbol added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 18, 2020

juanarbol pushed a commit that referenced this pull request

Apr 18, 2020 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

@ddazal ddazal deleted the ddazal/child-process-serialization-early-return branch

April 18, 2020 22:05

BethGriggs pushed a commit that referenced this pull request

Apr 27, 2020 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Apr 28, 2020 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

targos pushed a commit that referenced this pull request

Apr 30, 2020 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

lpinca added a commit to lpinca/node that referenced this pull request

May 15, 2020

lpinca added a commit that referenced this pull request

May 16, 2020 
Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

codebytere pushed a commit that referenced this pull request

May 16, 2020 
Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

lpinca added a commit to lpinca/node that referenced this pull request

Jul 9, 2020

codebytere pushed a commit that referenced this pull request

Jul 13, 2020 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

codebytere pushed a commit that referenced this pull request

Jul 14, 2020 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>