Home Original page

http: doc deprecate abort and improve docs by ronag · Pull Request #32807 · nodejs/node

@nodejs-github-bot added the doc

Issues and PRs related to the documentations.

label

Apr 13, 2020

ronag

ronag

@ronag 

Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: nodejs#32225

@ronag

mcollina

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 13, 2020

@mcollina mcollina added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Apr 13, 2020

himself65

@ronag

addaleax

Co-Authored-By: Anna Henningsen <github@addaleax.net>

@ronag

@addaleax addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 13, 2020

ronag added a commit that referenced this pull request

Apr 26, 2020 
Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: #32225

PR-URL: #32807
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 27, 2020 
Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: #32225

PR-URL: #32807
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax pushed a commit that referenced this pull request

Apr 27, 2020 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2020 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BridgeAR pushed a commit that referenced this pull request

Apr 28, 2020 
Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: #32225

PR-URL: #32807
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Apr 28, 2020 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BridgeAR pushed a commit that referenced this pull request

Apr 28, 2020 
Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: #32225

PR-URL: #32807
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Apr 28, 2020 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2020 
Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: #32225

PR-URL: #32807
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2020 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request

Apr 28, 2020 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)

PR-URL: #33103

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2020 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request

Apr 28, 2020 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103

dr-js added a commit to dr-js/dr-js that referenced this pull request

Apr 29, 2020 
notable change:
- node: use `request.destroy()|request.destroyed` instead of `request.abort()|request.aborted` follow: nodejs/node#32807
- package update

dr-js added a commit to dr-js/dr-node that referenced this pull request

Apr 29, 2020 
notable change:
- node: use `request.destroy()|request.destroyed` instead of `request.abort()|request.aborted` follow: nodejs/node#32807
- add: `extractTgzOrTarAsync` to `module/Software/7z`
- script explorer compress code
- package update

BethGriggs added a commit that referenced this pull request

Apr 29, 2020 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103

BethGriggs added a commit that referenced this pull request

Apr 29, 2020 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103

dr-js added a commit to dr-js/dr-js that referenced this pull request

Jul 10, 2020 
notable change:
- deprecated: `objectDeleteUndefined` from `common/immutable/Object`
- deprecated: node: `requestAsync` from `node/net`
- deprecated: node: `urlString` option in `createWebSocketClient` from `node/server/WebSocket/WebSocketClient`
- break: sort `Async*` code:
  - use `AsyncFuncQueue` instead of `AsyncTaskQueue` (previous one)
  - use `AsyncLane` with `Async*Queue` support instead of `AsyncTaskLane` (previous one)
  - use `AsyncTaskQueue` instead of `AsyncTaskRunner`
  - use `AsyncTaskQueue + AsyncLane` instead of `AsyncTaskRunnerCluster`
- break: use `prettyStringifyTreeNode` instead of `prettyStringifyTree`
- break: node: mass code sort for `node/file/`:
  - drop `node/file/function`, use `fs` directly
  - default to `getPathLstat` so most symlink will be kept
  - sort `node/file/Directory`:
    - use `getDirInfoList` instead of `getDirectorySubInfoList`
    - use `getDirInfoTree` instead of `getDirectoryInfoTree`
    - use `walkDirInfoTreeAsync` instead of `walkDirectoryInfoTree`
    - use `walkDirInfoTreeBottomUpAsync` instead of `walkDirectoryInfoTreeBottomUp`
    - use `copyDirInfoTree` instead of `copyDirectoryInfoTree`
    - use `renameDirInfoTree` instead of `renameDirectoryInfoTree`
    - use `deleteDirInfoTree` instead of `deleteDirectoryInfoTree`
- break: node: mass code sort in `node/data/Stream`:
  - use `readableStreamToBufferAsync` instead of `receiveBufferAsync` from `node/data/Buffer`
  - use `writeBufferToStreamAsync` instead of `sendBufferAsync` from `node/data/Buffer`
  - use `waitStreamStopAsync(setupStreamPipe( ... ))` instead of `pipeStreamAsync`
  - use `readlineOfStreamAsync` instead of `createReadlineFromStreamAsync`
- break: node: use `getDefaultOpenCommandList` instead of `getDefaultOpen`
- break: node: use `request.destroy()|request.destroyed` instead of `request.abort()|request.aborted` follow: nodejs/node#32807
- break: node: use `response.writableEnded` (need `nodejs@>=12.9`)
- break: browser: use `onProgressUpload/onProgressDownload` instead of `onUploadProgress/onDownloadProgress` for `fetchLikeRequest`
- fix: ci: git CRLF config & longer test timeout
- fix: ci: patch `libgbm1` for `puppeteer@3`, check: puppeteer/puppeteer#5674
- fix: better handle WebSocket `doUpgradeSocket` error
- fix: sanity test for `nodejs@14`
- fix: flaky test `fetchLikeRequest() option: timeout` in `net.test.js`
- fix: code lint for `eslint-config-almost-standard-v14`
- add: `onProgressUpload/onProgressDownload` for both `fetchLikeRequest`
- add: `AsyncTask` and `AsyncTaskQueue`
- add: `catchPromise` to `common/error`
- add: `.sanity.test` for some peace of mind
- add: `typeNameOf` to `common/format`
- add: tree-like structure support in `common/data/Tree`
- add: node: support pass `ReadableStream` as `body` to `fetchLikeRequest`
- add: node: `isReadableStream/isWritableStream`
- add: node: `ResolveCommand` moved from `@dr-js/node`
- add: node: TLS server session ticket rotation
- add: browser: `browser/net.test.js`
- add: bin: percent for mode `fetch`
- ci: update `.gitignore` & `.github/workflows/ci-test.yml`
- better `error.stack` for `withTimeoutPromise|withTimeoutAsync`
- simplify `createInsideOutPromise` code
- sort test file naming
- package update

notable change from `0.2.1-dev.*`:
- add: `isRegExp|regexp` in `common/check|verify`
- add: `createMarkReplacer` to `common/string`
- add: node: `closeAsync|readAsync|writeAsync|readlinkAsync|symlinkAsync` to `node/file/function`
- add: node: `resolvePath` to `createOptionGetter` in `node/module/Option/preset`
- fix: node: leaked `error` event in `createReadlineFromStreamAsync`
- node: update `buffer.readUInt*()` usage for removed `noAssert` since `nodejs@10`
- node: sort `node/module/Option/preset` code
- sort build script
- package update

dr-js added a commit to dr-js/dr-node that referenced this pull request

Jul 11, 2020 
notable change:
- deprecated: use `PATH_RENAME` instead of `PATH_MOVE`
- deprecated: `fileTLS*` option of `configureServerPack` from `module/ServerPack`, use `TLSSNIConfig|TLSDHParam` instead
- deprecated: bin: `file-TLS-*` option, use `TLS-SNI-config|TLS-dhparam` instead
- break: use `ResolveCommand` from `@dr-js/core`
- break: use `request.destroy()|request.destroyed` instead of `request.abort()|request.aborted` follow: nodejs/node#32807
- break: drop `TaskAction` module and `TaskRunner` feature to allow later to add improved version
- break: bin: merge `compress/extract` to use `module/Software/archive`
- break: bin: use `TLS-SNI-config` instead of `https` to enable https
- add: `REGEXP_AUTO|REGEXP_T7Z|REGEXP_TXZ` to `module/Software/archive`
- add: `REGEXP_NPM_TAR|extractPackageJson` to `module/Software/npmTar`
- add: `toPackageTgzName` to `module/Software/npm`
- add: `AuthCommonOption` to `server/feature/Auth/option` to allow set `authKey`
- add: `RuntimeDump` for getting runtime heap status & use `setupPackageSIGUSR2`
- add: `module/Software/archive` and `module/Software/npmTar`
- add: `module/TerminalStatusBar`
- add: `module/TerminalColor` & `module/Software/npm` from `@dr-js/dev`
- add: `createCommandWrap` for `module/Software/7z|git|tar` to allow reset command
- add: feature: `WebSocketTunnelDev` (under DEV)
- fix: code lint for `eslint-config-almost-standard-v14`
- ci: run on all 3 platform & test `nodejs@14`
- script sort
- package update

notable change from `0.2.1-dev.*`:
- add: `module/FsPack`
- add: `module/ResolveCommand`
- add: `module/RunDetached`
- add: `resolveCommand|resolveCommandAsync` and `pingRaceUrlList|pingStatUrlList`
- add: explorer: add route `/timestamp` for server time & ping
- add: bin: mode `ping-race|ping-stat` & option `debug-route`
- fix: `TLSSNIConfig` value normalize in `ServerPack`
- sort script
- package update