Home Original page

stream: fix handling generators in Readable.from by vadzim · Pull Request #32844 · nodejs/node

@vadzim changed the title Fix handling generators in readable from Fix handling generators in stream.Readable.from

Apr 14, 2020

ronag

mcollina

ronag

ronag

ronag

@ronag ronag added the stream

Issues and PRs related to the stream subsystem.

label

Apr 14, 2020

ronag

@vadzim

ronag

@vadzim

@vadzim

mcollina

@vadzim

@vadzim

@vadzim vadzim changed the title Fix handling generators in stream.Readable.from stream: fix handling generators in Readable.from

Apr 17, 2020

mcollina

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 17, 2020

ronag pushed a commit that referenced this pull request

Apr 18, 2020 
Call iterator.return() if not all of its values are consumed.

Fixes: #32842

PR-URL: #32844
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

BethGriggs pushed a commit that referenced this pull request

Apr 27, 2020 
Call iterator.return() if not all of its values are consumed.

Fixes: #32842

PR-URL: #32844
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

BridgeAR pushed a commit that referenced this pull request

Apr 28, 2020 
Call iterator.return() if not all of its values are consumed.

Fixes: #32842

PR-URL: #32844
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

targos pushed a commit that referenced this pull request

May 7, 2020 
Call iterator.return() if not all of its values are consumed.

Fixes: #32842

PR-URL: #32844
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

targos pushed a commit that referenced this pull request

May 13, 2020 
Call iterator.return() if not all of its values are consumed.

Fixes: #32842

PR-URL: #32844
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>