Home Original page

Proposal: crypto: Make the digest parameter required for pbkdf2. by tomgco · Pull Request #3292 · nodejs/node

@tomgco 

This change will remove the default behaviour of defaulting to SHA1
as its digest function, instead this will break backwards compatibility
and force implementors to choose a secure digest that is suited for them
at that time.

@bnoordhuis added crypto

Issues and PRs related to the crypto subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Oct 9, 2015

tomgco added a commit to tomgco/node that referenced this pull request

Jan 22, 2016 
As per nodejs#3292, this PR introduces a deprecation notice about removing
the 'default digest' overload which currently defaults to the soon
to be defunct SHA1 digest.

Instead it should be left up to the documentation and implementor to
suggest a suitable digest function.

shigeki pushed a commit that referenced this pull request

Jan 22, 2016 
As per #3292, this PR introduces a deprecation notice about removing
the 'default digest' overload which currently defaults to the soon
to be defunct SHA1 digest.

Instead it should be left up to the documentation and implementor to
suggest a suitable digest function.

Ref: #3292
PR-URL: #4047
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016 
As per nodejs#3292, this PR introduces a deprecation notice about removing
the 'default digest' overload which currently defaults to the soon
to be defunct SHA1 digest.

Instead it should be left up to the documentation and implementor to
suggest a suitable digest function.

Ref: nodejs#3292
PR-URL: nodejs#4047
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

This was referenced

Feb 20, 2022

This was referenced

Sep 29, 2022

This was referenced

Oct 5, 2022

This was referenced

Oct 8, 2022

This was referenced

May 13, 2024

This was referenced

May 14, 2024

This was referenced

May 14, 2024

This was referenced

May 22, 2024

This was referenced

May 23, 2024