Home Original page

stream: finished should complete with read-only Duplex by ronag · Pull Request #32967 · nodejs/node

@ronag ronag added the stream

Issues and PRs related to the stream subsystem.

label

Apr 21, 2020

@ronag 

If passed a Duplex where readable or writable has been
explicitly disabled then don't assume 'close' will be
emitted.

Fixes: nodejs#32965

mcollina

@ronag

@ronag

mafintosh

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 21, 2020

juanarbol

ronag added a commit that referenced this pull request

Apr 23, 2020 
If passed a Duplex where readable or writable has been
explicitly disabled then don't assume 'close' will be
emitted.

Fixes: #32965

PR-URL: #32967
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

ronag added a commit to nxtedition/node that referenced this pull request

Apr 23, 2020 
An unfortunate overlap between two PR that by themselves pass
CI but together pass a test.

nodejs#32967 changes so that
pipeline does not wait for 'close'.

nodejs#32968 changed so that
all streams are not destroyed.

Which made one test fail when expected the stream to be
destroyed during pipeline callback.

@ronag ronag mentioned this pull request

Apr 23, 2020

4 tasks

BridgeAR pushed a commit that referenced this pull request

Apr 23, 2020 
An unfortunate overlap between two PR that by themselves pass
CI but together pass a test.

#32967 changes so that
pipeline does not wait for 'close'.

#32968 changed so that
all streams are not destroyed.

Which made one test fail when expected the stream to be
destroyed during pipeline callback.

PR-URL: #33030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This was referenced

Apr 25, 2020

BethGriggs pushed a commit that referenced this pull request

Apr 27, 2020 
If passed a Duplex where readable or writable has been
explicitly disabled then don't assume 'close' will be
emitted.

Fixes: #32965

PR-URL: #32967
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 27, 2020 
An unfortunate overlap between two PR that by themselves pass
CI but together pass a test.

#32967 changes so that
pipeline does not wait for 'close'.

#32968 changed so that
all streams are not destroyed.

Which made one test fail when expected the stream to be
destroyed during pipeline callback.

PR-URL: #33030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>