Home Original page

[v10.x] deps: fix V8 compiler error with clang++-11 by sam-github · Pull Request #33094 · nodejs/node

@addaleax addaleax changed the title deps: fix V8 compiler error with clang++-11 [v10.x] deps: fix V8 compiler error with clang++-11

Apr 27, 2020

addaleax

@sam-github @richardlau 

Fixes: nodejs#33040

		  error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to 'bool'
			  in initializer list [-Wc++11-narrowing]
			ParameterList result{{}, {}, context->VARARGS(), {}};

Occurs twice:
		../../deps/v8/src/torque/ast-generator.cc:123:32:
		../../deps/v8/src/torque/ast-generator.cc:144:32:

richardlau

richardlau pushed a commit that referenced this pull request

Jul 1, 2020 
Fixes: #33040

  error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to
    'bool' in initializer list [-Wc++11-narrowing]
  ParameterList result{{}, {}, context->VARARGS(), {}};

Occurs twice:
  ../../deps/v8/src/torque/ast-generator.cc:123:32:
  ../../deps/v8/src/torque/ast-generator.cc:144:32:

PR-URL: #33094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>