Home Original page

doc: add warning for socket.connect reuse by ronag · Pull Request #33204 · nodejs/node

@ronag 

`socket.connect` is subtly broken due to timing and
_undestroy issues. Discourage usage and ask users
to instead create a new socket instance.

Refs: nodejs#33203

mcollina

@ronag

mscdex

@ronag

addaleax

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 8, 2020

mcollina

ronag added a commit that referenced this pull request

May 8, 2020 
PR-URL: #33204
Refs: #25969
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

codebytere pushed a commit that referenced this pull request

May 11, 2020 
PR-URL: #33204
Refs: #25969
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@ronag ronag mentioned this pull request

May 27, 2020

5 tasks

codebytere pushed a commit that referenced this pull request

Jun 7, 2020 
PR-URL: #33204
Refs: #25969
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>