Home Original page

src: fix compiler warning in async_wrap.cc by addaleax · Pull Request #33322 · nodejs/node

@addaleax 

    ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
    ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
     }

Refs: nodejs#32891

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

May 9, 2020

addaleax added a commit that referenced this pull request

May 9, 2020 
    ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
    ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
     }

Refs: #32891

PR-URL: #33322
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

codebytere pushed a commit that referenced this pull request

May 11, 2020 
    ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
    ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
     }

Refs: #32891

PR-URL: #33322
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>