Home Original page

Revert "vm: add importModuleDynamically option to compileFunction" by mcollina · Pull Request #33364 · nodejs/node

@nodejs-github-bot nodejs-github-bot added doc

Issues and PRs related to the documentations.

tools

Issues and PRs related to the tools directory.

vm

Issues and PRs related to the vm subsystem.

labels

May 12, 2020

BridgeAR

targos

@mcollina

benjamingr

BethGriggs

mhdawson

mcollina added a commit that referenced this pull request

May 15, 2020 
This reverts commit 74c393d.

Fixes: #33166

PR-URL: #33364
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

codebytere pushed a commit that referenced this pull request

May 16, 2020 
This reverts commit 74c393d.

Fixes: #33166

PR-URL: #33364
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

devsnek added a commit to devsnek/node that referenced this pull request

Sep 29, 2020

devsnek added a commit to devsnek/node that referenced this pull request

Feb 5, 2021

devsnek added a commit to devsnek/node that referenced this pull request

Feb 5, 2021

devsnek added a commit that referenced this pull request

Feb 5, 2021 
This reverts commit 2d5d773.

See: #32985
See: #33364
See: #33166
Fixes: #31860

PR-URL: #35431
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

danielleadams pushed a commit that referenced this pull request

Feb 16, 2021 
This reverts commit 2d5d773.

See: #32985
See: #33364
See: #33166
Fixes: #31860

PR-URL: #35431
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>