Home Original page

lib: update executionAsyncId/triggerAsyncId comment by danbev · Pull Request #33396 · nodejs/node

@nodejs-github-bot added the async_hooks

Issues and PRs related to the async hooks subsystem.

label

May 14, 2020

legendecas

@danbev 

This commit updates the comment referring to the
executionAsyncId/triggerAsyncId pair being stored in a std::stack.

It looks like this was changed from std::stack to AliasedFloat64Array in
Commit 83e5215 ("async_hooks: use
typed array stack as fast path").

danbev added a commit that referenced this pull request

May 20, 2020 
This commit updates the comment referring to the
executionAsyncId/triggerAsyncId pair being stored in a std::stack.

It looks like this was changed from std::stack to AliasedFloat64Array in
Commit 83e5215 ("async_hooks: use
typed array stack as fast path").

PR-URL: #33396
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@danbev danbev deleted the async_hooks_async_ids_stack_comment branch

May 20, 2020 09:32

codebytere pushed a commit that referenced this pull request

Jun 18, 2020 
This commit updates the comment referring to the
executionAsyncId/triggerAsyncId pair being stored in a std::stack.

It looks like this was changed from std::stack to AliasedFloat64Array in
Commit 83e5215 ("async_hooks: use
typed array stack as fast path").

PR-URL: #33396
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Jul 6, 2020 
This commit updates the comment referring to the
executionAsyncId/triggerAsyncId pair being stored in a std::stack.

It looks like this was changed from std::stack to AliasedFloat64Array in
Commit 83e5215 ("async_hooks: use
typed array stack as fast path").

PR-URL: #33396
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>