Home Original page

module: remove dynamicInstantiate loader hook by hybrist · Pull Request #33501 · nodejs/node

@nodejs-github-bot added errors

Issues and PRs related to JavaScript errors originated in Node.js core.

esm

Issues and PRs related to the ECMAScript Modules implementation.

labels

May 21, 2020

devsnek

@hybrist 

The dynamicInstantiate loader hook requires that the hooks run in the
same global scope as the code being loaded. We don't want to commit to
this being true in the future. It stops us from sharing hooks between
multiple worker threads or isolating loader hook from the application
code.

Using `getSource` and `getGlobalPreloadCode` the same use cases should
be covered.

hybrist

devsnek

GeoffreyBooth

guybedford

@hybrist hybrist added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 26, 2020

hybrist added a commit that referenced this pull request

May 27, 2020 
The dynamicInstantiate loader hook requires that the hooks run in the
same global scope as the code being loaded. We don't want to commit to
this being true in the future. It stops us from sharing hooks between
multiple worker threads or isolating loader hook from the application
code.

Using `getSource` and `getGlobalPreloadCode` the same use cases should
be covered.

PR-URL: #33501
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>

@GeoffreyBooth GeoffreyBooth removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 27, 2020

codebytere pushed a commit that referenced this pull request

Jun 18, 2020 
The dynamicInstantiate loader hook requires that the hooks run in the
same global scope as the code being loaded. We don't want to commit to
this being true in the future. It stops us from sharing hooks between
multiple worker threads or isolating loader hook from the application
code.

Using `getSource` and `getGlobalPreloadCode` the same use cases should
be covered.

PR-URL: #33501
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>

codebytere pushed a commit that referenced this pull request

Jun 30, 2020 
The dynamicInstantiate loader hook requires that the hooks run in the
same global scope as the code being loaded. We don't want to commit to
this being true in the future. It stops us from sharing hooks between
multiple worker threads or isolating loader hook from the application
code.

Using `getSource` and `getGlobalPreloadCode` the same use cases should
be covered.

PR-URL: #33501
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>

yorkie added a commit to alibaba/pipcook that referenced this pull request

Jul 15, 2020 
See nodejs/node#33501
At Node.js 14.5.0, it removes the dynamic module format, so we need to
make compatible works for the new usage with esm loader.

Node.js Release PR: nodejs/node#34093

This was referenced

Jul 15, 2020

yorkie added a commit to alibaba/pipcook that referenced this pull request

Jul 15, 2020 
See nodejs/node#33501
At Node.js 14.5.0, it removes the dynamic module format, so we need to
make compatible works for the new usage with esm loader.

Node.js Release PR: nodejs/node#34093

gindis pushed a commit to gindis/pipcook that referenced this pull request

Sep 11, 2020 
See nodejs/node#33501
At Node.js 14.5.0, it removes the dynamic module format, so we need to
make compatible works for the new usage with esm loader.

Node.js Release PR: nodejs/node#34093