wasi: refactor and enable poll_oneoff() test by cjihrig · Pull Request #33521 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 23, 2020

addaleax

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 23, 2020

gengjiawen

Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: nodejs#33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: nodejs#33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere pushed a commit that referenced this pull request

Jun 18, 2020
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere pushed a commit that referenced this pull request

Jun 18, 2020
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere pushed a commit that referenced this pull request

Jun 30, 2020
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere pushed a commit that referenced this pull request

Jun 30, 2020
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere pushed a commit that referenced this pull request

Jul 8, 2020
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere pushed a commit that referenced this pull request

Jul 8, 2020
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

codebytere added a commit that referenced this pull request

Jul 13, 2020
Notable changes:

deps:
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 14, 2020
Notable changes:

deps:
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 16, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 17, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 21, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 21, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 22, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

codebytere added a commit that referenced this pull request

Jul 22, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343

cjihrig pushed a commit that referenced this pull request

Jul 23, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343