Home Original page

test: fix flaky test-net-connect-econnrefused by Trott · Pull Request #34330 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jul 13, 2020

richardlau

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jul 13, 2020

@Trott Trott added the flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

label

Jul 15, 2020

addaleax

Trott added a commit that referenced this pull request

Jul 15, 2020 
Test is flaky in CI with `common.PORT` but not flaky if a port is
determined from createServer() first.

PR-URL: #34330
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@Trott Trott deleted the fix-flaky-econn branch

July 15, 2020 17:18

cjihrig pushed a commit that referenced this pull request

Jul 23, 2020 
Test is flaky in CI with `common.PORT` but not flaky if a port is
determined from createServer() first.

PR-URL: #34330
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Jul 27, 2020 
Test is flaky in CI with `common.PORT` but not flaky if a port is
determined from createServer() first.

PR-URL: #34330
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request

Sep 22, 2020 
Test is flaky in CI with `common.PORT` but not flaky if a port is
determined from createServer() first.

PR-URL: #34330
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit that referenced this pull request

Sep 22, 2020 
Test is flaky in CI with `common.PORT` but not flaky if a port is
determined from createServer() first.

PR-URL: #34330
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>