Home Original page

test: fix test-net-pingpong pummel test for non-IPV6 hosts by Trott · Pull Request #34359 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jul 14, 2020

@Trott Trott changed the title test: fix test-net-pingpong pummel test for containers test: fix test-net-pingpong pummel test for non-IPV6 hosts

Jul 15, 2020

@Trott Trott marked this pull request as ready for review

July 15, 2020 02:24

addaleax

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jul 16, 2020

BridgeAR

tniessen

@Trott Trott deleted the pingpoing-fix branch

July 16, 2020 21:29

cjihrig pushed a commit that referenced this pull request

Jul 23, 2020 
Use `common.hasIPv6` instead of an OS check for more reliable
operation.

PR-URL: #34359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit that referenced this pull request

Jul 27, 2020 
Use `common.hasIPv6` instead of an OS check for more reliable
operation.

PR-URL: #34359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax pushed a commit that referenced this pull request

Sep 22, 2020 
Use `common.hasIPv6` instead of an OS check for more reliable
operation.

PR-URL: #34359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax pushed a commit that referenced this pull request

Sep 22, 2020 
Use `common.hasIPv6` instead of an OS check for more reliable
operation.

PR-URL: #34359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>