Home Original page

test: remove common.localhostIPv6 by Trott · Pull Request #34373 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jul 14, 2020

richardlau

@Trott Trott changed the title test: remove common.localhostIPv6() test: remove common.localhostIPv6

Jul 15, 2020

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jul 15, 2020

Trott added a commit that referenced this pull request

Jul 16, 2020 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the remove-unused branch

July 16, 2020 23:59

cjihrig pushed a commit that referenced this pull request

Jul 23, 2020 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 27, 2020 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request

Sep 22, 2020 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request

Sep 22, 2020 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>