Home Original page

module: fix check for package.json at volume root by DerekNonGeneric · Pull Request #34595 · nodejs/node

GeoffreyBooth

guybedford

guybedford

DerekNonGeneric

DerekNonGeneric

guybedford

ljharb

DerekNonGeneric

DerekNonGeneric

@guybedford 

This patch converts the "read package scope" algorithm's while loop
into a do-while loop enabling items at the filesystem root dir to
be considered within the scope of a sibling package.json also at the
filesystem root dir.

Fixes: #33438

Co-authored-by: Guy Bedford <guybedford@gmail.com>

This was referenced

Aug 14, 2020

mmarchini

nodejs-github-bot pushed a commit that referenced this pull request

Aug 15, 2020 
This patch converts the "read package scope" algorithm's while loop
into a do-while loop enabling items at the filesystem root dir to
be considered within the scope of a sibling package.json also at the
filesystem root dir.

Fixes: #33438

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #34595
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>

This was referenced

Aug 16, 2020

MylesBorins pushed a commit that referenced this pull request

Aug 17, 2020 
This patch converts the "read package scope" algorithm's while loop
into a do-while loop enabling items at the filesystem root dir to
be considered within the scope of a sibling package.json also at the
filesystem root dir.

Fixes: #33438

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #34595
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>

This was referenced

Aug 18, 2020

BethGriggs pushed a commit that referenced this pull request

Aug 20, 2020 
This patch converts the "read package scope" algorithm's while loop
into a do-while loop enabling items at the filesystem root dir to
be considered within the scope of a sibling package.json also at the
filesystem root dir.

Fixes: #33438

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #34595
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>

guybedford pushed a commit to guybedford/node that referenced this pull request

Sep 28, 2020 
This patch converts the "read package scope" algorithm's while loop
into a do-while loop enabling items at the filesystem root dir to
be considered within the scope of a sibling package.json also at the
filesystem root dir.

Fixes: nodejs#33438

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: nodejs#34595
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>

codebytere pushed a commit that referenced this pull request

Oct 1, 2020 
This patch converts the "read package scope" algorithm's while loop
into a do-while loop enabling items at the filesystem root dir to
be considered within the scope of a sibling package.json also at the
filesystem root dir.

Fixes: #33438

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #34595
Backport-PR-URL: #35385
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>