Home Original page

test: fix test_worker_terminate_finalization by addaleax · Pull Request #34726 · nodejs/node

@addaleax 

The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in nodejs#34625.

@addaleax added fast-track

PRs that do not need to wait for 72 hours to land.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Aug 11, 2020

richardlau

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 11, 2020

addaleax added a commit that referenced this pull request

Aug 11, 2020 
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.

PR-URL: #34726
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 17, 2020 
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.

PR-URL: #34726
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Aug 20, 2020 
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.

PR-URL: #34726
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

addaleax added a commit that referenced this pull request

Sep 22, 2020 
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.

PR-URL: #34726
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

addaleax added a commit that referenced this pull request

Sep 22, 2020 
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.

PR-URL: #34726
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>