Home Original page

[v10.x] http2: support non-empty DATA frame with END_STREAM flag by clshortfuse · Pull Request #34857 · nodejs/node

and others added 2 commits

August 20, 2020 13:53
Some small fixes on HTTP/2 and its documentation:

 - Add a note that, on server streams, it's not necessary
   to start data flow.

 - Set EOF flag if we have marked all data for sending:
   there's no need to wait until the queue is
   actually empty (and send a separate, empty DATA).

   (Note that, even with this change, a separate DATA
   frame will always be sent, because the streams
   layer waits until data has been flushed before
   dispatching EOF)

PR-URL: nodejs#28044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

http2

Issues or PRs related to the http2 subsystem.

v10.x labels

Aug 20, 2020

@MylesBorins MylesBorins changed the title http2: [v10.x] support non-empty DATA frame with END_STREAM flag [v10.x] http2: support non-empty DATA frame with END_STREAM flag

Aug 20, 2020

richardlau

richardlau pushed a commit that referenced this pull request

Oct 7, 2020 
Some small fixes on HTTP/2 and its documentation:

 - Add a note that, on server streams, it's not necessary
   to start data flow.

 - Set EOF flag if we have marked all data for sending:
   there's no need to wait until the queue is
   actually empty (and send a separate, empty DATA).

   (Note that, even with this change, a separate DATA
   frame will always be sent, because the streams
   layer waits until data has been flushed before
   dispatching EOF)

PR-URL: #28044
Backport-PR-URL: #34857
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

richardlau pushed a commit that referenced this pull request

Oct 7, 2020