Home Original page

test: separate the test fixtures between ICU and URL by Leko · Pull Request #35077 · nodejs/node

@Leko 

We need to emit dependency of ICU's toASCII in order to update the WPT
fixtures. Since ICU and URL isn't the same implementation and they also
follow different specifications. ICU's toASCII shouldn't have a
dependency on WPT fixtures.

Refs: #33770 (comment)

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Sep 6, 2020

joyeecheung

watilde pushed a commit that referenced this pull request

Sep 8, 2020 
We need to emit dependency of ICU's toASCII in order to update the WPT
fixtures. Since ICU and URL isn't the same implementation and they also
follow different specifications. ICU's toASCII shouldn't have a
dependency on WPT fixtures.

Refs: #33770 (comment)
PR-URL: #35077
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@Leko Leko deleted the split-fixtures branch

September 8, 2020 11:37

ruyadorno pushed a commit that referenced this pull request

Sep 17, 2020 
We need to emit dependency of ICU's toASCII in order to update the WPT
fixtures. Since ICU and URL isn't the same implementation and they also
follow different specifications. ICU's toASCII shouldn't have a
dependency on WPT fixtures.

Refs: #33770 (comment)
PR-URL: #35077
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request

Jan 8, 2021 
We need to emit dependency of ICU's toASCII in order to update the WPT
fixtures. Since ICU and URL isn't the same implementation and they also
follow different specifications. ICU's toASCII shouldn't have a
dependency on WPT fixtures.

Refs: nodejs#33770 (comment)
PR-URL: nodejs#35077
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>