Home Original page

doc: change type of child_process.signalCode to string by SimplyLinn · Pull Request #35223 · nodejs/node

@nodejs-github-bot added child_process

Issues and PRs related to the child_process subsystem.

doc

Issues and PRs related to the documentations.

labels

Sep 16, 2020

@SimplyLinn SimplyLinn changed the title doc: change type of child_proccess.signalCode to string doc: change type of child_process.signalCode to string

Sep 16, 2020

addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 21, 2020

@Trott 

During testing, and interfacing with child_processes, I found that the
child_process.signalCode property to be the string representation of
the signal, not number.

PR-URL: nodejs#35223
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 24, 2020 
During testing, and interfacing with child_processes, I found that the
child_process.signalCode property to be the string representation of
the signal, not number.

PR-URL: #35223
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request

Jan 8, 2021 
During testing, and interfacing with child_processes, I found that the
child_process.signalCode property to be the string representation of
the signal, not number.

PR-URL: nodejs#35223
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>