[v12.x backport] CJS exports detection by guybedford · Pull Request #35405 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@guybedford

Copy link

Contributor

@guybedford guybedford commented

Sep 29, 2020

edited

Loading

This backports the CJS exports detection from #35249 and the error message adjustments from #35426 for 12.x.

This PR is based to the modules backports PR at #35385 so should land after that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@codebytere codebytere codebytere approved these changes

+1 more reviewer

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src

Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@guybedford @nodejs-github-bot @codebytere @MylesBorins @aduh95 @mcollina @GeoffreyBooth @mmarchini