Home Original page

tools,test: enable multiline-comment-style rule in tests by Trott · Pull Request #35485 · nodejs/node

@nodejs-github-bot added async_hooks

Issues and PRs related to the async hooks subsystem.

test

Issues and PRs related to the tests.

labels

Oct 3, 2020 
Enforce `//` for multiline comments. Some tests mixed and matched, and
at least one did so in a (to me) surprising way.

PR-URL: nodejs#35485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Use `//` for multline comments.

PR-URL: nodejs#35485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the test-multiline-comments branch

October 7, 2020 11:37

BethGriggs pushed a commit that referenced this pull request

Oct 13, 2020 
Enforce `//` for multiline comments. Some tests mixed and matched, and
at least one did so in a (to me) surprising way.

PR-URL: #35485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Oct 13, 2020 
Use `//` for multline comments.

PR-URL: #35485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request

Jan 8, 2021 
Enforce `//` for multiline comments. Some tests mixed and matched, and
at least one did so in a (to me) surprising way.

PR-URL: nodejs#35485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request

Jan 8, 2021 
Use `//` for multline comments.

PR-URL: nodejs#35485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>