console: prevent internal timers storage from growing by narqo · Pull Request #3562

console: prevent internal timers storage from growing by narqo · Pull Request #3562 · nodejs/node

added the console

Issues and PRs related to the console subsystem.

label

Oct 28, 2015

targos added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Oct 28, 2015

The instance of `Console` class doesn't remove links to arrays that
come from hrtimer after `timeEnd` had been called.

cjihrig pushed a commit that referenced this pull request

Nov 13, 2015

Currently, console timers that have been ended with timeEnd()
are not removed. This has the potential to leak memory. This
commit deletes ended timers from the containing Map.

PR-URL: #3562
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

This was referenced

Apr 28, 2016

jasnell pushed a commit that referenced this pull request

Apr 30, 2016

Unintended functionality was removed from console.endTime by
#3562. Prior to that, you could
call console.endTime multiple times for the same label.

PR-URL: #6454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>

Fishrock123 pushed a commit that referenced this pull request

May 4, 2016

Unintended functionality was removed from console.endTime by
#3562. Prior to that, you could
call console.endTime multiple times for the same label.

PR-URL: #6454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>

joelostrowski pushed a commit to joelostrowski/node that referenced this pull request

May 4, 2016

Unintended functionality was removed from console.endTime by
nodejs#3562. Prior to that, you could
call console.endTime multiple times for the same label.

PR-URL: nodejs#6454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>