Home Original page

test: use global.EventTarget instead of internals by aduh95 · Pull Request #36002 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Nov 6, 2020

benjamingr

@aduh95 aduh95 added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 7, 2020

@aduh95 

`EventTarget` is exposed on the global scope, there is no need to use
`--expose-internals` flag in the tests.

Refs: nodejs#35496

PR-URL: nodejs#36002
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@aduh95 aduh95 deleted the test-global-eventtarget branch

November 9, 2020 18:26

danielleadams pushed a commit that referenced this pull request

Nov 10, 2020 
`EventTarget` is exposed on the global scope, there is no need to use
`--expose-internals` flag in the tests.

Refs: #35496

PR-URL: #36002
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>