timers: cleanup abort listener on awaitable timers by jasnell · Pull Request #36006

timers: cleanup abort listener on awaitable timers by jasnell · Pull Request #36006 · nodejs/node

added the timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

label

Nov 6, 2020

Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 7, 2020

benjamingr added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Nov 9, 2020

nodejs-github-bot pushed a commit that referenced this pull request

Nov 9, 2020

Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

danielleadams pushed a commit that referenced this pull request

Nov 9, 2020

Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos added a commit that referenced this pull request

May 16, 2021

Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Jun 11, 2021

Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

deokjinkim added a commit to deokjinkim/node that referenced this pull request

Apr 28, 2023

nodejs-github-bot pushed a commit that referenced this pull request

May 3, 2023

Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>

targos pushed a commit that referenced this pull request

May 3, 2023

Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>

targos pushed a commit that referenced this pull request

May 3, 2023

Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023

Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

Jul 6, 2023

Use `getEventListeners` instead of `listenerCount` because nodejs#35991
was landed.

Refs: nodejs#35991
Refs: nodejs#36006
PR-URL: nodejs#47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>