Home Original page

test: remove flaky designation for test-http2-large-file by Trott · Pull Request #37156 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jan 31, 2021

@Trott Trott added the flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

label

Jan 31, 2021

Qard

Qard approved these changes Jan 31, 2021

richardlau

gireeshpunathil

@Trott 

This seems to have stopped happening, possibly because it only ever
happened on win2008 and that went eol last year.

Closes: nodejs#22327

PR-URL: nodejs#37156
Fixes: nodejs#22327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the win2008-no-more branch

February 3, 2021 18:04

danielleadams pushed a commit that referenced this pull request

Feb 16, 2021 
This seems to have stopped happening, possibly because it only ever
happened on win2008 and that went eol last year.

Closes: #22327

PR-URL: #37156
Fixes: #22327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Feb 16, 2021

targos pushed a commit that referenced this pull request

May 1, 2021 
This seems to have stopped happening, possibly because it only ever
happened on win2008 and that went eol last year.

Closes: #22327

PR-URL: #37156
Fixes: #22327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>