tools: fix typo in natural-compare/README.md by eltociear · Pull Request #37366 · nodejs/node
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 35.1k
Closed
tools: fix typo in natural-compare/README.md#37366
eltociear wants to merge 1 commit intonodejs:masterfrom
eltociear:patch-3
tools: fix typo in natural-compare/README.md#37366
eltociear wants to merge 1 commit intonodejs:masterfrom
eltociear:patch-3
Conversation
comparision -> comparison
Copy link
Member
RaisinTen
commented
Feb 14, 2021
RaisinTen commented
Feb 14, 2021I believe this change should be done at natural-compare's own repo: https://github.com/litejs/natural-compare-lite
Copy link
Member
targos
commented
Feb 14, 2021
targos commented
Feb 14, 2021Yes, sorry @eltociear, we cannot accept this change because it's in a dependency that we include without modifications.
targos
closed this
Copy link
Contributor Author
eltociear
commented
Feb 14, 2021
eltociear commented
Feb 14, 2021@RaisinTen @targos Thanks announcement!
I understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants